Dhairya-007 opened a new pull request, #30089:
URL: https://github.com/apache/camel/pull/30089

   ## Problem
   
   Two header `javaType` values name their class by simple name only, while the 
rest of the component's headers are fully qualified:
   
   ```json
   "CamelMongoDbSortBy":          { ..., "javaType": "Bson or Document" }
   "CamelMongoDbCollectionIndex": { ..., "javaType": "List<Bson>" }
   ```
   
   compared with their neighbours in the same file:
   
   ```json
   "CamelMongoDbCriteria":        { ..., "javaType": 
"org.bson.conversions.Bson" }
   "CamelMongoDbOperationHeader": { ..., "javaType": 
"org.apache.camel.component.mongodb.MongoDbOperation or String" }
   ```
   
   So `org.bson.conversions.Bson` is published under two different names in one 
component, and in the two places where it is written short it is also paired 
with `Document`, which is `org.bson.Document` and not `org.w3c.dom.Document` - 
the type most readers of a Camel component will assume from a bare `Document`.
   
   Fully qualified is the convention by a wide margin across the whole catalog: 
3692 header `javaType` values are fully qualified or a built-in type, and 151 
are not.
   
   ## Fix
   
   Qualify both, to the same FQNs the component's other headers already use. 
The `List` spelling is left alone. Header names are untouched.
   
   Metadata only - no behaviour change. I diffed the regenerated catalog file 
against `main` and confirmed these two `javaType` values are the only fields 
that differ.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to