gnodet-bot commented on code in PR #30051: URL: https://github.com/apache/camel/pull/30051#discussion_r4579769714
########## components/camel-spring-parent/camel-spring-rabbitmq/src/main/docs/spring-rabbitmq-component.adoc: ########## @@ -152,6 +152,17 @@ Configure the endpoint with the settings of the existing elements, or turn the d (on the endpoint or the component), or for some elements with `skipDeclareExchange`, `skipDeclareQueue` or `skipBindQueue`. +The consumer declares them again each time the connection factory opens a new connection, for example after the +connection to RabbitMQ was lost: a queue that RabbitMQ deleted meanwhile, such as an auto-delete or exclusive queue, is +declared again when the consumer reconnects. + +When RabbitMQ is not available when the consumer starts, the consumer logs a warning and starts anyway: the listener +container keeps trying to connect, and the exchange, queue and binding are declared when it connects. +To fail the start instead, set `testConnectionOnStartup=true`. Review Comment: 💬 **Doc nit (low):** 35-word run-on sentence with passive voice (“are declared”) and 3 conjunctions. Consider splitting: ```suggestion When RabbitMQ is not available at startup, the consumer logs a warning and starts anyway. The listener container retries the connection, and the consumer declares the exchange, queue and binding once it connects. To fail the start instead, set `testConnectionOnStartup=true`. ``` ########## components/camel-spring-parent/camel-spring-rabbitmq/src/main/docs/spring-rabbitmq-component.adoc: ########## @@ -152,6 +152,17 @@ Configure the endpoint with the settings of the existing elements, or turn the d (on the endpoint or the component), or for some elements with `skipDeclareExchange`, `skipDeclareQueue` or `skipBindQueue`. +The consumer declares them again each time the connection factory opens a new connection, for example after the +connection to RabbitMQ was lost: a queue that RabbitMQ deleted meanwhile, such as an auto-delete or exclusive queue, is +declared again when the consumer reconnects. Review Comment: 💬 **Doc nit (low):** 43-word sentence with passive voice (“is declared again”). Consider splitting for clarity: ```suggestion The consumer declares them again each time the connection factory opens a new connection, for example after losing the connection to RabbitMQ. This re-declares queues that RabbitMQ deleted in the meantime, such as auto-delete or exclusive queues. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
