Croway opened a new pull request, #30232:
URL: https://github.com/apache/camel/pull/30232

   JIRA: [CAMEL-27062](https://issues.apache.org/jira/browse/CAMEL-27062)
   
   - Since CAMEL-23526 the cxf and cxfrs producers select the operation from 
`CamelCxfOperationName` (and, for cxf, `CamelCxfOperationNamespace`). A route 
that still set `operationName` got no hint that the header is not read. The cxf 
producer invoked the first operation that CXF returns, which comes from a hash 
map and is not the first one of the WSDL. The cxfrs proxy producer failed with 
`Cannot find method with name: null`. Both sent the former header to the 
service as an HTTP header.
   - camel-cxf (`CxfProducer`): logs a WARN, once per producer, when 
`operationName` or `operationNamespace` is set without its replacement, and 
when neither the header nor `defaultOperationName` selects the operation of a 
service with more than one operation. The "Can't find the BindingOperationInfo" 
error names `CamelCxfOperationName`, `CamelCxfOperationNamespace` and the 
`defaultOperationName`/`defaultOperationNamespace` options, and lists the 
operations of the service.
   - camel-cxf-rest (`CxfRsProducer`): with the proxy-based client API, the 
`NoSuchMethodException` names `CamelCxfOperationName` when it is not set, and 
says that `operationName` is not read when it is set. Every such exchange 
fails, so the error is the hint and there is no WARN.
   - `CxfHeaderFilterStrategy` filters `operationName` and `operationNamespace` 
again, and `CxfRsHeaderFilterStrategy` filters `operationName` again, as they 
did before the rename. The former headers stay unread: the rename is not 
reverted.
   - The cxf and cxfrs component pages say how the operation is picked and that 
the former header names are not read.
   
   Tests:
   - `CxfProducerOperationHeaderTest` (new, camel-cxf-soap): the 3 tests for 
the former header, the unselected operation and the error message fail before 
and pass after; the 4 controls (the header selects each operation, the header 
wins over a former-name header, `defaultOperationName`, a service with one 
operation: no WARN) pass before and after.
   - `CxfRsProducerOperationHeaderTest` (new, camel-cxf-rest, 9 runs): the 
missing-header error and the former-header error (sync and async, 4 runs) and 
the former header sent as an HTTP header (proxy and HTTP centric client APIs) 
fail before and pass after; the 4 controls (the header selects the method, sync 
and async; the header wins over a former-name header; an unknown method keeps 
its error) pass before and after. `CxfRsHeaderFilterStrategyTest` gets a check 
for both names.
   - The other camel-cxf-common, camel-cxf-transport, camel-cxf-soap and 
camel-cxf-rest tests, and the cxfrs producer and consumer tests of 
camel-cxf-spring-rest, pass.
   
   Upgrade guide: `camel-4x-upgrade-guide-4_24.adoc`, "camel-cxf, camel-cxfrs - 
the former operationName and operationNamespace headers are not sent".
   
   _Claude Code on behalf of Federico Mariani_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to