davsclaus opened a new pull request, #3148:
URL: https://github.com/apache/camel-kamelets/pull/3148
_Claude Code on behalf of Claus Ibsen_
A batch of Kamelets rewritten to the documentation standard proposed in
#3140, `docs/modules/ROOT/pages/documenting.adoc`, like #3141–#3147.
This batch has 16 AWS Kamelets:
- `aws-s3-sink`, `aws-s3-streaming-upload-sink` and
`aws-s3-event-based-source`;
- `aws-sqs-source`, `aws-sqs-sink`, `aws-sqs-batch-sink` and
`aws-sqs-fifo-sink`;
- `aws-sns-sink` and `aws-sns-fifo-sink`;
- `aws-ses-sink`;
- `aws-kinesis-source`, `aws-kinesis-sink` and `aws-kinesis-firehose-sink`;
- `aws-eventbridge-sink`, `aws-cloudwatch-sink` and `aws-cloudtrail-source`.
`aws-s3-source` (in #3140) is the model.
**The AWS options are now described the same way across the family:**
- where to get the access key and secret key;
- the region, with an example;
- the default, profile and session credentials;
- the endpoint override for LocalStack or MinIO.
**All but `aws-cloudtrail-source` were run** against an AWS emulator.
`aws-s3-event-based-source` and `aws-eventbridge-sink` were also run on Camel
4.23.0.
## Facts that were missing or wrong before
- **`aws-s3-sink`:**
- the `file` header is the key, unless `keyName` is set;
- `Content-Type` is not used; only `CamelAwsS3ContentType` sets the stored
type.
- **`aws-s3-streaming-upload-sink`:**
- messages are joined with no separator, into files named `keyName`, `-1`,
`-2`, ...;
- its partial page claimed a `file` header names the file.
- **`aws-sqs-source`:**
- it never reads message attributes;
- with `deleteAfterRead=false`, messages come back after the visibility
timeout.
- **`aws-sqs-sink`:** the other headers become message attributes.
- **`aws-sqs-batch-sink`:** splits the text at `batchSeparator`.
- **`aws-sqs-fifo-sink` and `aws-sns-fifo-sink`:**
- the group comes from the `group` header;
- `aws-sns-fifo-sink`'s `contentBasedDeduplication` talked about an "SQS
FIFO queue".
- **`aws-ses-sink`:** `to` is required and `reply-to-addresses` optional.
Its partial page said the opposite.
- **`aws-kinesis-sink`:** the `partition` header is the partition key; its
partial page said `file`.
- **`aws-kinesis-source`:** it rereads the whole stream from the oldest
record on every start.
- **`aws-eventbridge-sink`:** the three header paragraphs are rewritten.
Each of resource ARN, detail type and source comes from a header or an option.
- **`aws-cloudwatch-sink`:** `metric-name` is required; the value defaults
to 1 and the unit to Count.
## Found on the way, not changed here
- **`aws-s3-event-based-source` with `getObject=true` fails on Camel 4.24.**
Its `unmarshalType` is a Jackson 2 `JsonNode`, as in the other batches.
- **`aws-s3-streaming-upload-sink` (a component bug, for apache/camel):**
with the Kamelet default `restartingPolicy=lastPart`, a `keyName` whose file
name has a dash (`my-app.log`) fails the second start. The error is
`NumberFormatException` in `AWS2S3StreamUploadProducer.setStartingPart`.
- **`aws-cloudtrail-source`:** the default `maxResults: 1`, combined with
page draining on each poll since Camel 4.23, makes the first poll fetch up to
90 days of events, one per request.
- **Other problems:**
- `aws-sqs-source`'s `CamelAwsSqsMD5OfBody` header has the default
`application/octet-stream`;
- its `minimum` and `maximum` are strings;
- `aws-ses-sink` has no endpoint override.
- **Commonly needed component options none of these Kamelets expose:**
- a proxy;
- `storageClass` and KMS encryption for S3;
- `messageAttributeNames` for SQS, without which attributes are always
empty;
- `iteratorType` for Kinesis;
- fixed `to` and `subject` options for SES.
These are for a follow-up.
## Notes for review
- No template, type, default or required list was changed. The one new
`enum` is on `aws-s3-streaming-upload-sink` `namingStrategy`: `progressive`,
`random` and `timestamp`, the component's values. The `dataTypes` blocks are
`headers` only, with no `default`.
- `KameletsCatalogTest.testSupportedHeaders`: `aws-s3-sink` 51 → 2. The
catalog now returns the headers the Kamelet declares instead of those of the S3
component.
- This PR is based on `main`; if #3140 merges first, I will rebase it and
regenerate the index.
`./mvnw clean install` from the root passes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]