davsclaus opened a new pull request, #3150:
URL: https://github.com/apache/camel-kamelets/pull/3150

   _Claude Code on behalf of Claus Ibsen_
   
   A batch of Kamelets rewritten to the documentation standard proposed in 
#3140, `docs/modules/ROOT/pages/documenting.adoc`, like #3141–#3149.
   
   This batch has the 18 Azure Kamelets and 11 partial pages: Blob Storage 
(sink, append sink, source, change feed source, event-based source), Queue 
Storage, Data Lake, Files, Event Hubs, Service Bus, Cosmos DB and Functions.
   
   ## How they were checked
   
   | Kamelets | Checked |
   |---|---|
   | Blob and Queue Storage | Run against Azurite (`camel infra run azure`). |
   | `azure-functions-sink` | Run against a local HTTP server. |
   | Data Lake, Files, Event Hubs, Service Bus, Cosmos DB | Checked against the 
template, the component documentation and the component code. No emulator was 
available for them. |
   
   ## Facts that were missing or wrong before
   
   - **`azure-storage-blob-sink`:**
     - the `file` header names the blob, and a `/` makes virtual folders;
     - a missing container fails the message.
   - **`azure-storage-blob-append-sink`:**
     - appends the bytes exactly as sent, with no newline;
     - appending to a block blob fails.
   - **`azure-storage-blob-source` reads every blob again on every poll** 
unless `deleteAfterRead` is set. Blobs in folders are read too.
   - **`azure-storage-queue-sink`:**
     - `expiration` must be an ISO-8601 duration such as `PT10M`; a plain 
number fails;
     - its partial page named the wrong header (`partition`) and the wrong 
default expiry.
   - **`azure-storage-queue-source`:** a failed message comes back after 30 
seconds.
   - **The Data Lake and Files sources** never delete, and read again on every 
poll. The Data Lake source reads only top-level files.
   - **`azure-eventhubs-source`:** without a checkpoint, starts at the latest 
event, in consumer group `$Default`.
   - **Service Bus:** `AZURE_IDENTITY` and `TOKEN_CREDENTIAL` also need the 
namespace.
   - **`azure-cosmosdb-sink`:** a missing partition key fails.
   - **`CLIENT_SECRET` in the blob Kamelets' credential types:** the partial 
pages said `clientId`, `clientSecret` and `tenantId` are used with it. They are 
used only with `AZURE_IDENTITY`; `CLIENT_SECRET` falls back to the default 
Azure credential.
   - **A typo:** the header name `amelAzureStorageDataLakeCopyProgress` is 
fixed.
   
   ## Found on the way, not changed here
   
   - **`azure-storage-blob-changefeed-source`:**
     - does not start on Camel 4.24, because of the Jackson 2 `JavaTimeModule`;
     - on 4.23 it cannot marshal the `OffsetDateTime` of an event, so it likely 
fails on every real event;
     - it reads the whole change feed on every poll.
   - **`azure-storage-blob-source` with `deleteAfterRead=true`:**
     - the delete uses the blob name header as it is when processing ends;
     - a blob sink further on changes that header, so the delete misses, and 
the blob is copied again on every poll.
   - **`azure-storage-blob-event-based-source`:**
     - a blob in a virtual folder fails, because the name is taken after the 
last `/`;
     - `serviceBusType` is never set, so topics cannot be used.
   - **Required options and credential types that do not fit:**
     - the queue `accessKey` is required even with `AZURE_IDENTITY`;
     - the Data Lake `clientId`, `clientSecret` and `tenantId` are required for 
every credential type;
     - several credential types need options the Kamelets do not pass;
     - some header types (`long`, `java.time.Instant`) are not JSON Schema 
types.
   - **Commonly needed component options these Kamelets do not expose:**
     - a blob prefix or regex;
     - an Event Hubs consumer group and start position;
     - Service Bus sessions and the dead-letter queue;
     - a Cosmos DB upsert;
     - a change feed start time.
   
     These are for a follow-up.
   
   ## Notes for review
   
   - No template, type, default or required list was changed. The `dataTypes` 
blocks are `headers` only, with no `default`.
   - `KameletsCatalogTest.testSupportedHeaders`: the catalog now returns the 
headers these Kamelets declare instead of those of their components. The 
changed counts:
     - `azure-servicebus-source` 21 → 7
     - `azure-storage-blob-sink` 46 → 2
     - `azure-storage-datalake-sink` 37 → 2
     - `azure-storage-queue-sink` 16 → 2
   - This PR is based on `main`; if #3140 merges first, I will rebase it and 
regenerate the index.
   
   `./mvnw clean install` from the root passes.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to