allthingssecurity commented on PR #30249: URL: https://github.com/apache/camel/pull/30249#issuecomment-6943394336
@davsclaus thanks for checking it against Curator and ZooKeeper. 1. Merge order with #30137: agreed, whichever lands second turns the `stopWhileSuspended` / `stopDuringCreate` cases (and `writesAfterInterrupt`) on by default and drops the `mustWaitToStop` excuse. 2. Done in 553a9352c9fe (on top of your rebase): the close now asks only `client.getZookeeperClient().isConnected()`. I used it for the delete of the recorded znode too, since the foreground guaranteed delete there has the same problem when the group's flag lags behind the client. A disconnected client still gets the background delete. 3. The case left open is noted on CAMEL-27037. 4. Backport: noted in the description, 4.22.x and 4.18.x. camel-zookeeper-master unit tests: 43 run, 0 failures (the three `ZooKeeperGroupCloseTest` cases included). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
