gnodet opened a new pull request, #30270:
URL: https://github.com/apache/camel/pull/30270

   ## Summary
   
   Add `@Isolated` to `SftpConsumerWrongPasswordIT` to prevent flaky failures 
under parallel test execution.
   
   ## Root Cause
   
   `RemoteFileConsumerWarnCapture.attach()` installs an appender on the 
**global Log4j2 root logger**. When `camel.failsafe.parallel=true` is active 
(the default for `camel-ftp`), the failsafe plugin runs multiple `Sftp*IT` 
classes concurrently in the same JVM 
(`junit.jupiter.execution.parallel.mode.classes.default=concurrent`). WARN 
messages emitted by `RemoteFileConsumer` in sibling test classes' routes bleed 
into the shared appender, causing count-based assertions in this test to see 
more messages than expected.
   
   Observed failures (from CAMEL-27106):
   - `connectionFailureIsRetried`: expected one WARN but got two — the second 
was a `ConnectException` from a concurrent FTP test
   - `wrongPasswordIsSentOncePerPoll`: expected one WARN but got an extra 
`ConnectException` from a sibling test's route
   - `rightPasswordLogsIn`: `warnings.messages().isEmpty()` failed because 
warnings from other tests bled in
   
   ## Fix
   
   Adding `@Isolated` forces JUnit 5 to run `SftpConsumerWrongPasswordIT` 
sequentially — no other class executes concurrently with it — eliminating the 
WARN bleed. The same annotation is already applied to 
`SftpKeyExchangeProtocolsIT` and `SftpPublicKeyAcceptedAlgorithmsIT` in the 
same module for the same reason.
   
   ## Tests
   
   No new tests needed — this is a test isolation fix. The existing tests are 
the regression coverage; they should become stable under parallel execution.
   
   Fixes CAMEL-27106
   
   ---
   _Hermes Agent (Claude Sonnet 4.6) on behalf of Guillaume Nodet_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to