davsclaus opened a new pull request, #3168: URL: https://github.com/apache/camel-kamelets/pull/3168
Part of #3162, group 2: `http-sink` and `http-source` get the login options of `http-secured-sink` and `http-secured-source`, and the secured variants are deprecated. The secured Kamelets were the plain template plus eight optional parameters of the HTTP component. Those options are now on the plain Kamelets, with the same names, titles and descriptions, so they are all optional: - Basic, Digest and NTLM login: `authMethod`, `authUsername`, `authPassword`, `authenticationPreemptive` - OAuth 2.0 client credentials: `oauth2ClientId`, `oauth2ClientSecret`, `oauth2TokenEndpoint`, `oauth2Scope` Without them, the plain Kamelets work as before. ### Deprecation, not removal `http-secured-sink` and `http-secured-source` keep working, unchanged: - Their support level is now `Deprecated`. - The first sentence of their description says to use `http-sink` or `http-source`. - Their description says they will be removed in a later release, and that moving means changing only the name of the Kamelet, because the options are the same. This is the mechanism proposed in #3162 for Kamelets that work and may be in use. The broken and unused ones went straight to removal in #3165 and #3166. ### Other changes - The descriptions of `http-sink`, `http-source` and `rest-openapi-sink` no longer send readers to the secured variants. Instead, the "Good to know" paragraph of `http-sink` and `http-source` says how to log in. - `security-model.adoc` listed `http-source` and `http-secured-source` among the sources that "open a `platform-http` listener". Both poll a URL and open no listener, so they are taken out of that sentence. ### Verification I ran a local HTTP server that checks credentials, and every case worked: | Case | Result | |---|---| | `http-sink`, Basic login, not preemptive | 401, then 200 with the credentials | | `http-sink`, Basic login, `authenticationPreemptive: true` | 200 on the first request | | `http-sink`, OAuth 2.0 | A token is fetched from the token URL (client credentials), then sent as `Bearer` | | `http-sink`, no login | 200; the query in the URL is kept and no `Authorization` header is sent | | `http-source`, Basic login | 200 | | `http-source`, no login | 200 | `./mvnw clean install` passed twice, the first time with `-DskipTests`. _Claude Code on behalf of Claus Ibsen_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
