davsclaus opened a new pull request, #3169:
URL: https://github.com/apache/camel-kamelets/pull/3169

   Part of #3162, group 2: `jms-apache-artemis-sink` and 
`jms-apache-artemis-source` get the options of their pooled variants, and 
`jms-pooled-apache-artemis-*` are deprecated.
   
   ### What changes
   
   - **Login on both plain Kamelets:** they get `username` and `password`. 
Until now they had no login options, so a broker that needs a login could only 
be reached by putting the password in `brokerURL`. When the options are not 
set, the Kamelet connects with no login, as before.
   - **The sink is now pooled:** `jms-apache-artemis-sink` sends through a 
`JmsPoolConnectionFactory` from pooled-jms, the same one the pooled sink uses.
     - It gets the 3 pool options with the same defaults: 
`maxSessionsPerConnection`, `maxIdleSessionsPerConnection` and 
`connectionIdleTimeout`.
     - It gets the `pooled-jms` 3.2.6 dependency.
     - Without the pool, the JMS producer opened a new connection to the broker 
for every message.
   - **The source stays unpooled:** a listener keeps its connection open, so a 
pool adds nothing there. The pooled source's pool options have no counterpart 
on the plain source.
   - **Deprecated, not removed:** `jms-pooled-apache-artemis-sink` and 
`jms-pooled-apache-artemis-source` keep working, unchanged.
     - Their support level is `Deprecated`.
     - The first sentence of the description and a note on the doc page point 
to the plain Kamelets.
     - Moving the sink means changing only the name of the Kamelet. Moving the 
source also means dropping the pool options.
   - **Docs:** the partial pages of the plain Kamelets now describe the login, 
and for the sink also the pool. The topic example uses `username` and 
`password` instead of credentials in the URL.
   - **Other descriptions:** `jms-amqp-10-sink` and `jms-amqp-10-source` no 
longer mention the pooled variants.
   
   ### Verification
   
   I tested against two Apache Artemis brokers in Docker, one that requires a 
login and one that allows anonymous clients:
   
   | Case | Result |
   |---|---|
   | Sink and source with `username` and `password`, against the login broker | 
20 of 20 messages received |
   | Sink and source without a login, against the anonymous broker | 5 of 5 
received. An unset `username` stays unset (`null`), not an empty user. |
   | Sink without a login, against the login broker | Refused (`AMQ229031 
Unable to validate user ... Username: null`) |
   | Connections opened by the broker for 20 messages, sink from `main` 
(unpooled) | 20 |
   | Connections opened by the broker for 20 messages, sink from this PR 
(pooled) | 1, plus 1 for the source |
   
   `./mvnw clean install` passed twice, the first time with `-DskipTests`.
   
   _Claude Code on behalf of Claus Ibsen_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to