saravanakumar1987 opened a new pull request, #30297:
URL: https://github.com/apache/camel/pull/30297

   # Description
   
   Fixes [CAMEL-27137](https://issues.apache.org/jira/browse/CAMEL-27137).
   
   ## What was wrong
   
   The Surefire configuration of the profile `full` in `parent/pom.xml` 
includes only `**/*Test.java`. The names of four test classes in 
`org.apache.camel.component.spring.ws.addressing` end in `Tests` instead:
   
   - `ConsumerWSANewChannelParamsActionTests`
   - `ConsumerWSANewChannelParamsToTests`
   - `ConsumerWSASameChannelParamsActionTests`
   - `ConsumerWSASameChannelParamsToTests`
   
   Each class inherits 12 tests from `AbstractConsumerTests`. Four of them have 
`@Disabled`. So the build did not run 32 enabled tests. The section "Tests" of 
the description of apache/camel#30223 already noted that the build did not run 
these classes. Commit 16c85783bb2e added the four classes in 2012 for 
CAMEL-5815.
   
   ## The change
   
   This commit renames the four files from `…Tests.java` to `…Test.java`. It 
renames the class in each declaration to match. Nothing else changes.
   
   ## Tests
   
   The four classes test the WS-Addressing Action header of the response and of 
a SOAP fault that the consumer returns. The routes set `outputAction`, 
`faultAction`, both or neither. Two classes use the endpoint mapping type 
`action`, and two use the type `to`. For each type, one class sends the request 
without a ReplyTo address, and one with a ReplyTo address. This commit adds no 
test and changes no test logic.
   
   ## How it was verified
   
   - Before the rename, `mvn -o -B test` in the module ran 111 tests, 17 of 
them skipped. No test failed or had an error, and Surefire reran none. The 23 
Surefire reports included none of the four classes.
   - Run by name with `-Dtest` and `-Dsurefire.rerunFailingTestsCount=0`, each 
of the four classes ran 12 tests, 4 of them skipped. None failed or had an 
error.
   - After the rename, `mvn install -nsu` in the module ran three times, with 
the files of this commit. Each time, it ran 159 tests, 33 of them skipped. No 
test failed or had an error, and Surefire reran none. In each run, each renamed 
class ran 12 tests, 4 of them skipped.
   - The module sets `camel.surefire.parallel=true`, so JUnit runs the test 
classes concurrently. Each test creates its own Spring application context. 
`CamelSpringTestSupport` creates it before each test and closes it after the 
test. Requests and replies go through `InMemoryWebServiceMessageSender2`. It 
hands each message to the receiver in memory, so the tests use no port.
   
   ## Not changed
   
   - `AbstractConsumerTests` and `AbstractWSATests` keep their names, as they 
are abstract.
   - The two context files keep their names, as the classes load them by a 
fixed path.
   - The four disabled tests stay disabled.
   - The Surefire configuration does not change.
   - Outside this module, the only file under `src/test/java` whose name ends 
in `Tests.java` is `JavaSocketManualTests` of camel-mllp. It has `@Disabled` on 
purpose, as its Javadoc explains.
   
   # Target
   
   - [x] I checked that the commit is targeting the correct branch (Camel 4 
uses the `main` branch)
   
   # Tracking
   
   - [x] If this is a large change, bug fix, or code improvement, I checked 
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for 
the change (usually before you start working on it).
   
   # Apache Camel coding standards and style
   
   - [x] I checked that each commit in the pull request has a meaningful 
subject line and body.
   - [x] I ran `mvn clean install -Dquickly -DskipTests` in the root folder at 
ed8ad1eb6ac5 of upstream `main`. That commit is the parent of this one. Then I 
ran `mvn install -nsu` in `components/camel-spring-parent/camel-spring-ws`, 
which also runs the formatter and the import sorter. These runs changed no 
generated file.
   
   I ran these commands:
   
   ```
   # in components/camel-spring-parent/camel-spring-ws, before the rename
   mvn -o -B test
   mvn -o -B test 
-Dtest=ConsumerWSANewChannelParamsActionTests,ConsumerWSANewChannelParamsToTests,ConsumerWSASameChannelParamsActionTests,ConsumerWSASameChannelParamsToTests
 -Dsurefire.failIfNoSpecifiedTests=false -Dsurefire.rerunFailingTestsCount=0
   # in the same folder, after the rename, three times
   mvn install -nsu
   ```
   
   # AI-assisted contributions
   
   - [x] If this PR includes AI-generated code, commits have proper 
co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR 
description identifies the AI tool used.
   
   Claude Code (Anthropic) drafted the change and this text, from the ticket 
and the code of camel-spring-ws. It also used `parent/pom.xml` and 
`CamelSpringTestSupport` of camel-test-spring-junit6. Claude Code ran the tests 
as described above.
   
   _Claude Code on behalf of saravanakumar1987_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to