luigidemasi opened a new pull request, #185: URL: https://github.com/apache/camel-kit/pull/185
Migrates standalone `camel-kit` and the `camel kit` plugin to Aesh 3.19.1 and Camel's `CommandTree` plugin SPI. Commands remain one-shot, with existing services/controllers and JLine/TamboUI rendering. The binding adapter preserves strict scalar options, collection arity, tokenized values, relative paths, help/version behavior, and interleaved Ship context. Invalid Ship operations fail with exit code 2 before state writes or worker launch. Plugin init now shares the standalone command implementation. Compatibility: - The plugin targets Camel 4.24.0-SNAPSHOT and requires Java 21; standalone Kit and Knowledge retain Java 17 support. Older Picocli hosts cannot load this plugin. The host pin is separate from generated integration defaults. - Camel expands argument files before loading plugins. For literal plugin context beginning with `@`, use `--text @@value` or `--text=@value` (likewise `--document`). Standalone Ship retains its existing literal behavior. This intentional syntax change is documented in the CLI reference and Ship guide. - A released Camel 4.24.0 host must be verified before releasing this Kit version. Local packaged acceptance used published snapshot `4.24.0-20261117.143648-37` and JLine 4.4.8. Validation: - Root `./mvnw -B clean install` on Java 21: all 13 modules passed; 2,239 tests passed, 11 existing conditional Knowledge skips, no failures/errors. Root `./mvnw -B -Psourcecheck validate` passed. - Focused standalone compatibility on Java 17: 89 tests passed. Core/plugin compatibility on Java 25: 105 tests passed. Java 17 CI reactor exclusion was also validated. - Final packaged JARs passed 18 process checks across both entry points: versions/help, doctor/graph/Ship JSON, invalid operations without state writes, silent init/regeneration, generated public skills and command prefixes. The plugin was discovered by Camel's real startup path. - Linux PTY comparison on Java 17/21/25: JLine-to-TamboUI handoff completed and post-exit terminal settings matched the Picocli baseline. Python tool tests (11), distribution mirrors, workflow YAML/shell branches and security-model YAML checks passed. - Added macOS/Windows Java 17/21/25 compatibility CI; these hosted results are pending. Runtime dependency closure increased from 32 JARs / 31,025,861 bytes to 37 JARs / 32,192,454 bytes (about 1.1 MiB). Linux/Temurin 21 process timings, milliseconds: | Command | Picocli first / subsequent median | Aesh first / subsequent median | | --- | ---: | ---: | | version | 577 / 589 | 679 / 460 | | help | 695 / 603 | 457 / 466 | | doctor JSON | 3,299 / 3,492 | 3,188 / 3,413 | Each median covers seven fresh JVMs after the first observed invocation. Filesystem caches were not flushed; these are local process measurements, not a controlled cold-cache or steady-state benchmark. Website impact: required and included in `docs/modules/ROOT/**`, together with contributor guidance and the changelog. Isolated Antora builds have the same six missing external cross-references as the baseline. Native macOS/Windows results depend on the new CI matrix; physical-terminal visual behavior and the complete website build were not checked locally. Fixes #171. _AI-generated by OpenAI Codex on behalf of @luigidemasi._ Generated by OpenAI Codex via /oss-fix-issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
