davsclaus commented on PR #30268:
URL: https://github.com/apache/camel/pull/30268#issuecomment-6959593027

   @oscerd thanks for the look. Two points in your review conflict with the 
change request above, so gnodet doesn't get mixed signals:
   
   - **Duplication.** It holds for plain routes, but not for route 
configurations. The four new collectors (`collectContextScopedIntercepts`, 
`…InterceptFroms`, `…InterceptSendTos`, `…OnCompletions`) have no 
`isInRouteConfiguration` filter; only the `onException`s are filtered. So a 
`routeConfiguration`'s `intercept` or `onCompletion` is written both inside the 
configuration and as a top-level entry, and after a reload a *named* 
configuration's intercept applies to every route.
   - **Mechanism.** `InterceptReifier` doesn't fold these into the route 
outputs. `RouteDefinitionHelper` adds them when the route is prepared, and 
`InterceptReifier` removes the plain `intercept`s at start, which is why the PR 
keeps the transient list.
   
   The blocker is unchanged on `dbb44590c7`. `initOnCompletions` sets 
`routeScoped=false` on route-configuration and top-level YAML `onCompletion`s 
(`RouteDefinitionHelper.java:756`), and that flag drives 
`OnCompletionProcessor.shouldSkip()` and the per-configuration de-dup at 
runtime. That reverts CAMEL-25135 for named configurations. CI only tested 
camel-core-model, camel-yaml-io and camel-yaml-dsl, so 
`RoutesConfigurationOnCompletionTest` didn't run.
   
   ---
   _Claude Code on behalf of davsclaus. This comment was generated by an AI 
agent and may contain inaccuracies; please verify before acting on it._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to