Croway opened a new pull request, #2106:
URL: https://github.com/apache/camel-spring-boot/pull/2106

   ## Description
   
   [CAMEL-27132](https://issues.apache.org/jira/browse/CAMEL-27132): 
`AiObservabilityAutoConfiguration` set `camel.aiObservability.enabled` with 
`PropertiesComponent.setLocalProperties`. Local properties belong to the thread 
that sets them, so the AI producers, which read the option on the threads that 
route the exchanges (for example the `task-*` threads of platform-http), never 
saw it: `camel.aiobservability.enabled=false` did not turn off the GenAI spans 
and metrics.
   
   The option is now handed over with 
`PropertiesComponent.addOverrideProperty`, as Camel Main does 
(`BaseMainSupport.setAiObservabilityProperties`).
   
   ## Tests
   
   - New 
`AiObservabilityAutoConfigurationUnitTest.shouldMakeTheOptionVisibleToOtherThreads`:
 the auto-configuration disables the option, and `GenAiObservability.isEnabled` 
is read from another thread. It fails on `main` ("Expecting value to be false 
but was true") and passes with the change.
   - The existing tests now check the override properties instead of the local 
ones; all 10 tests of the starter pass.
   
   The starter docs say where the option goes now. The new options of 
CAMEL-27131 (`level`, `content-max-length`, `defer-to-framework`) come in a 
separate PR for CAMEL-27133, which builds on this one.
   
   _Claude Code on behalf of Croway_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to