allthingssecurity commented on PR #30313:
URL: https://github.com/apache/camel/pull/30313#issuecomment-6973945266

   Thanks Claus, all three are real. Fixed in bb584f9:
   
   - **Children of the stepped exchange:** `awaitNode` now uses 
`isSingleStepped(exchange)`, which also matches the `CORRELATION_ID`, as 
`DefaultDebugger.getSingleStepBreakpoint` does. 
`testSplitPartWaitsForTheNodeAndSuspendsThere` single-steps a parallel split: 
one part is suspended at a node inside the split and the other waits for it; 
after a step, the part that waited must be suspended at that node.
   - **`stepBreakpoint()` in single step mode:** both `stepBreakpoint()` and 
`stepBreakpoint(nodeId)` now return after `step()`, as the log line says. 
Before this PR, `step()` had already continued every suspended exchange, so the 
fall-through found nothing; the only new thing it could find is the exchange 
that woke up, which must not be stepped on. 
`testStepBreakpointInSingleStepModeOnlySteps` goes through `stepBreakpoint()` 
and checks that the first exchange stays suspended at bar. Without the return 
it depends on which thread wins, so the test is not a reliable failure on the 
old code, but it pins the behaviour.
   - **Stale message on resume:** `suspendStep` now calls 
`removeMessageOf(toNode, exchangeId)` after every await, before `if (!hit)`, as 
`NodeBreakpoint` does.
   
   Nits: the interrupted path removes the message and `se` when it was 
registered, and the javadoc of `suspendStep` says the step can wait up to twice 
the fallback timeout.
   
   Targeted runs: the debugger and backlog tests of camel-management pass (52 
run, 0 failures), and `BacklogDebuggerStepIntoSuspendedNodeTest` passes 10 
times in one JVM (40/40).
   
   _Claude Code on behalf of allthingssecurity_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to