davsclaus commented on PR #3136:
URL: https://github.com/apache/camel-kamelets/pull/3136#issuecomment-6978195265
@jamesnetherton the catalog is now ready for 4.24, and this PR is what #3186
needs to go green, so could you rebase it on top of #3186's branch
(`davsclaus:quick-fix/camel-4.24.0-snapshot`, one commit on current `main`)?
What #3186's CI showed with Camel 4.24.0-SNAPSHOT:
- **`camel stop`:** the regression is fixed by CAMEL-27149, and the snapshot
of today 09:10 UTC has the fix.
- **Jackson, at startup:** 11 Citrus tests failed, all with the same error.
Camel JBang 4.24 has camel-jackson3 on its classpath, and the Kamelets add
camel-jackson. The `jackson` data format is then the Jackson 3 one, but its
configurer was looked up by name, which both jars register, and the Jackson 2
configurer won:
```
class org.apache.camel.component.jackson3.JacksonDataFormat cannot be cast
to class org.apache.camel.component.jackson.JacksonDataFormat
```
The affected tests are `json-deserialize-action` and the field actions
that use it, the avro and protobuf serdes and data-type tests, and the Jira
source test. This is fixed in Camel by
[CAMEL-27164](https://issues.apache.org/jira/browse/CAMEL-27164)
(apache/camel#30338, open).
- **Jackson, on the first message:** even with that fix, a Kamelet that sets
`unmarshalType: com.fasterxml.jackson.databind.JsonNode` starts but fails on
the first message (`Cannot construct instance of
com.fasterxml.jackson.databind.JsonNode`), because the Jackson 3 data format
cannot build the Jackson 2 type. Moving the Kamelets to Jackson 3, as this PR
does, is the fix we chose, rather than making Camel fall back to Jackson 2.
With this PR on top of #3186, the Kamelets no longer bring camel-jackson, so
the configurer clash should not happen even before CAMEL-27164 is in a
snapshot. Once the Integration Tests are green, #3186 and this PR can be merged
together. Several open #3170 PRs (#3192 to #3201) touch Kamelets that this PR
also changes, so whichever merges later gets rebased.
_Claude Code on behalf of Claus Ibsen_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]