davsclaus commented on code in PR #30338:
URL: https://github.com/apache/camel/pull/30338#discussion_r4620070112


##########
core/camel-main/src/main/java/org/apache/camel/main/MainHelper.java:
##########
@@ -501,7 +502,7 @@ public static PropertyConfigurer 
configurerByName(CamelContext context, String o
             return null;
         }
         PropertyConfigurer configurer
-                = 
PluginHelper.getConfigurerResolver(context).resolvePropertyConfigurer(name + 
"-" + kind, context);
+                = 
PropertyConfigurerHelper.resolvePropertyConfigurerByName(context, name + "-" + 
kind, target);
         // the configurer that PackageDataFormatMojo or PackageLanguageMojo 
generates for a type is named after it
         if (configurer != null && 
configurer.getClass().getName().equals(target.getClass().getName() + 
"Configurer")) {
             return configurer;

Review Comment:
   Kept as is. The exact class name check comes from CAMEL-26297: 
`configurerByName` returns a configurer only when it is the one generated for 
the class of the target, and otherwise returns `null`. With `null`, 
`MainHelper.setPropertiesOnTarget` looks up the configurer by the class name, 
and if there is none, `PropertyBindingSupport` resolves it per property with 
`PropertyConfigurerHelper.resolvePropertyConfigurer(camelContext, 
targetClass)`, which goes through the new hierarchy-aware lookup. So a 
configurer generated for a supertype is not lost; it is found on that path. 
jamesnetherton checked the same in his review.
   
   _Claude Code on behalf of davsclaus_



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to