gnodet-bot commented on code in PR #30263: URL: https://github.com/apache/camel/pull/30263#discussion_r4629492346
########## .github/actions/incremental-build/incremental-build-filter-test.sh: ########## @@ -0,0 +1,106 @@ +#!/usr/bin/env bash Review Comment: ⚠️ **Test never runs on CI.** The CI workflow (`.github/workflows/pr-ci-scripts-validation.yml`) uses `for test in *_test.sh` (underscore glob). This filename uses hyphens and is silently skipped — the PR description's claim that it is "picked up automatically" is incorrect until the rename. Existing test files use underscores: `pr_diff_test.sh`, `reactor_timing_test.sh`. Rename to `incremental_build_filter_test.sh`. (Originally raised by @davsclaus, still unaddressed after the latest commit.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
