lburgazzoli commented on a change in pull request #1013: feat(quarkus): Initial Quarkus support URL: https://github.com/apache/camel-k/pull/1013#discussion_r341114757
########## File path: pkg/trait/environment.go ########## @@ -63,7 +64,12 @@ func (t *environmentTrait) Apply(e *Environment) error { envvar.SetValFrom(&e.EnvVars, envVarPodName, "metadata.name") } - envvar.SetVal(&e.EnvVars, envVarMainClass, defaultMainClass) + quarkus := e.Catalog.GetTrait("quarkus").(*quarkusTrait) + if quarkus.isEnabled() { + quarkus.addContainerEnvironment(e) + } else { + envvar.SetVal(&e.EnvVars, envVarMainClass, defaultMainClass) Review comment: not something for now but we may think about creating a `runtime-main` trait and handle things homogeneously ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services