zregvart commented on a change in pull request #327: Search-Cancel Button
position fixes in the search box
URL: https://github.com/apache/camel-website/pull/327#discussion_r404851049
##########
File path: antora-ui-camel/src/css/header.css
##########
@@ -416,9 +416,9 @@ body {
#search-cancel {
position: relative;
- bottom: 1.4rem;
- left: 10.6rem;
- height: 1.1rem;
+ bottom: calc(50% - var(--body-font-size--desktop) / 7.5);
+ left: calc(100% - var(--body-font-size--desktop) / 0.9);
Review comment:
I thought that we don't put fixed values but reference a variable there (if
possible). These are [magic
numbers](https://en.wikipedia.org/wiki/Magic_number_%28programming%29) and if
we don't have a principle behind those, it's better to have one: a way to
correlate a change in one variable to a change in another. So if one changes we
don't have to look for other bits that need to change and we don't introduce
new issues. For example, and I'm not 100% on this, perhaps these can be derived
from `--doc-margin--desktop`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
