ppalaga commented on a change in pull request #1239:
URL: https://github.com/apache/camel-quarkus/pull/1239#discussion_r426890317



##########
File path: docs/modules/ROOT/pages/extensions/avro.adoc
##########
@@ -0,0 +1,38 @@
+[[avro]]
+= Avro Extension
+
+*Since Camel Quarkus 1.0.0-M6*
+
+The Avro extension provides link:https://avro.apache.org/[Avro schema based 
data serialization].
+
+Maven users will need to add the following dependency to their `pom.xml` for 
this extension.
+
+[source,xml]
+------------------------------------------------------------
+<dependency>
+    <groupId>org.apache.camel.quarkus</groupId>
+    <artifactId>camel-quarkus-avro</artifactId>
+</dependency>
+------------------------------------------------------------
+
+== Usage
+
+The extension provides support for the Camel 
https://camel.apache.org/components/latest/dataformats/avro-dataformat.html[Avro
 Data Format].
+
+=== Configuration
+
+Beyond standard usages described above, Camel Quarkus adds the possibility to 
parse the Avro schema at build time both in JVM and Native mode via the 
`@BuildTimeAvroDataFormat` annotation.
+
+For instance below, in a first step the `user.avsc` schema resource is parsed 
at build time.

Review comment:
       ```suggestion
   For instance below, in the first step the `user.avsc` schema resource is 
parsed at build time.
   ```

##########
File path: 
extensions/avro/runtime/src/main/java/org/apache/camel/quarkus/component/avro/AvroSchemaRegistry.java
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.avro;
+
+import java.util.HashMap;
+
+import org.apache.avro.Schema;
+
+public class AvroSchemaRegistry extends HashMap<String, Schema> {

Review comment:
       I have some concerns about this. Let me write more tomorrow.

##########
File path: docs/modules/ROOT/pages/extensions/avro.adoc
##########
@@ -0,0 +1,38 @@
+[[avro]]
+= Avro Extension
+
+*Since Camel Quarkus 1.0.0-M6*
+
+The Avro extension provides link:https://avro.apache.org/[Avro schema based 
data serialization].
+
+Maven users will need to add the following dependency to their `pom.xml` for 
this extension.
+
+[source,xml]
+------------------------------------------------------------
+<dependency>
+    <groupId>org.apache.camel.quarkus</groupId>
+    <artifactId>camel-quarkus-avro</artifactId>
+</dependency>
+------------------------------------------------------------
+
+== Usage
+
+The extension provides support for the Camel 
https://camel.apache.org/components/latest/dataformats/avro-dataformat.html[Avro
 Data Format].
+
+=== Configuration
+
+Beyond standard usages described above, Camel Quarkus adds the possibility to 
parse the Avro schema at build time both in JVM and Native mode via the 
`@BuildTimeAvroDataFormat` annotation.
+
+For instance below, in a first step the `user.avsc` schema resource is parsed 
at build time.
+In a second step, an AvroDataFormat instance using the previously parsed 
schema is injected in the `buildTimeAvroDataFormat` field at runtime. At the 
end of the day, the injected data format is used

Review comment:
       ```suggestion
   In the second step, an AvroDataFormat instance using the previously parsed 
schema is injected in the `buildTimeAvroDataFormat` field at runtime. At the 
end of the day, the injected data format is used
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to