Repository: carbondata Updated Branches: refs/heads/master 5936e7fb2 -> 8e6b0a7ce
[CARBONDATA-1599] Update pull request checklist Remove title and description items from pull request checklist, add them to How to contribute document This closes #1451 Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/8e6b0a7c Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/8e6b0a7c Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/8e6b0a7c Branch: refs/heads/master Commit: 8e6b0a7ce9ec9b5c2e9dc8e288f148d567224e28 Parents: 5936e7f Author: chenliang613 <chenliang...@apache.org> Authored: Mon Oct 30 01:00:56 2017 +0530 Committer: ravipesala <ravi.pes...@gmail.com> Committed: Tue Oct 31 12:16:02 2017 +0530 ---------------------------------------------------------------------- .github/PULL_REQUEST_TEMPLATE.md | 18 ++++-------------- docs/How-to-contribute-to-Apache-CarbonData.md | 8 ++++++-- 2 files changed, 10 insertions(+), 16 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/carbondata/blob/8e6b0a7c/.github/PULL_REQUEST_TEMPLATE.md ---------------------------------------------------------------------- diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0d9f60c..d80ff46 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,13 +1,5 @@ -Be sure to do all of the following to help us incorporate your contribution -quickly and easily: - - - [ ] Make sure the PR title is formatted like: - `[CARBONDATA-<Jira issue #>] Description of pull request` - - - [ ] Make sure to add PR description including - - - the root cause/problem statement - - What is the implemented solution +Be sure to do all of the following checklist to help us incorporate +your contribution quickly and easily: - [ ] Any interfaces changed? @@ -16,13 +8,11 @@ quickly and easily: - [ ] Document update required? - [ ] Testing done - Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - + - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. - ---- + http://git-wip-us.apache.org/repos/asf/carbondata/blob/8e6b0a7c/docs/How-to-contribute-to-Apache-CarbonData.md ---------------------------------------------------------------------- diff --git a/docs/How-to-contribute-to-Apache-CarbonData.md b/docs/How-to-contribute-to-Apache-CarbonData.md index 9048021..f57642d 100644 --- a/docs/How-to-contribute-to-Apache-CarbonData.md +++ b/docs/How-to-contribute-to-Apache-CarbonData.md @@ -152,9 +152,13 @@ $ git rebase -i origin/master Navigate to the CarbonData GitHub mirror to create a pull request. The title of the pull request should be strictly in the following format: ``` -[CARBONDATA-issue number>] Title of the pull request +[CARBONDATA-JiraTicketNumer][FeatureName] Description of pull request ``` -Please include a descriptive pull request message to help make the reviewerâs job easier. +Please include a descriptive pull request message to help make the reviewerâs job easier: +``` + - The root cause/problem statement + - What is the implemented solution + ``` If you know a good committer to review your pull request, please make a comment like the following. If not, donât worry, a committer will pick it up.