[ 
https://issues.apache.org/jira/browse/CASSANDRA-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855193#action_12855193
 ] 

Jonathan Ellis edited comment on CASSANDRA-821 at 4/8/10 10:49 PM:
-------------------------------------------------------------------

Okay, here's a cleanup in both patch-against-v1 and one-big-change formats.

Vs v1 the high-level overview is, r/m goToDataStart, IKeyColumnIterator, and 
ISSTableColumnIterator, rename SSTableColumnIterator -> 
SSTableIdentityIterator, rename ColumnIterator -> IColumnIterator, and clean up 
RowIteratorFactory & related code.

 delete mode 100644 src/java/org/apache/cassandra/db/IRowIterator.java
 create mode 100644 src/java/org/apache/cassandra/db/RowIterator.java
 delete mode 100644 src/java/org/apache/cassandra/db/RowIteratorImpl.java
 rename src/java/org/apache/cassandra/db/filter/{ColumnIterator.java => 
IColumnIterator.java} (87%)
 delete mode 100644 src/java/org/apache/cassandra/io/IKeyColumnIterator.java
 delete mode 100644 
src/java/org/apache/cassandra/io/sstable/ISSTableColumnIterator.java
 rename src/java/org/apache/cassandra/io/sstable/{SSTableColumnIterator.java => 
SSTableIdentityIterator.java} (85%)


      was (Author: jbellis):
    Okay, here's a cleanup in both patch-against-v1 and one-big-change formats.

Vs v1 the high-level overview is, r/m goToDataStart, IKeyColumnIterator, and 
ISSTableColumnIterator, rename SSTableColumnIterator -> 
SSTableIdentityIterator, and clean up RowIteratorFactory & related code.

 delete mode 100644 src/java/org/apache/cassandra/db/IRowIterator.java
 create mode 100644 src/java/org/apache/cassandra/db/RowIterator.java
 delete mode 100644 src/java/org/apache/cassandra/db/RowIteratorImpl.java
 rename src/java/org/apache/cassandra/db/filter/{ColumnIterator.java => 
IColumnIterator.java} (87%)
 delete mode 100644 src/java/org/apache/cassandra/io/IKeyColumnIterator.java
 delete mode 100644 
src/java/org/apache/cassandra/io/sstable/ISSTableColumnIterator.java
 rename src/java/org/apache/cassandra/io/sstable/{SSTableColumnIterator.java => 
SSTableIdentityIterator.java} (85%)

  
> get_range_slice performance
> ---------------------------
>
>                 Key: CASSANDRA-821
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-821
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 0.6
>            Reporter: Brandon Williams
>            Assignee: Johan Oskarsson
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 821-v2-diff.txt, 821-v2.txt, CASSANDRA-821.patch, 
> CASSANDRA-821.patch, CASSANDRA-821.patch, CASSANDRA-821.patch
>
>
> get_range_slice performance isn't that great.  CASSANDRA-799 helped in the 
> case when the memtable isn't flushed, but overall the operations per second 
> and latency is still pretty bad.  On a quad core node with a trivial amount 
> of data I see around 130-150 ops per second with stress.py set to slice 100 
> keys at a time, and latency is 300-500ms.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to