[ https://issues.apache.org/jira/browse/CASSANDRA-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857919#action_12857919 ]
Erick Tryzelaar commented on CASSANDRA-994: ------------------------------------------- Regarding removing the DatacenterEPS, there is the nice behavior of automatically determining the datacenter and rack from the ip address. Perhaps that mechanism should be merged into the PropertyFileSnitch? > re-organize endpointsnitch implementations > ------------------------------------------ > > Key: CASSANDRA-994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-994 > Project: Cassandra > Issue Type: Task > Reporter: Jonathan Ellis > Fix For: 0.7 > > > I think the EPS implementations should look like this: > IEndPointSnitch: rename to IEndpointSnitch (lowercase P), otherwise fine as > it is > SimpleSnitch: new default snitch. Implement IEPS directly, with sorting as > no-ops. > AbstractEndpointSnitch: rename to AbstractRackAwareSnitch; replace > isOnSameRack and isInSameDataCenter with getRack and getDatacenter (replacing > getLocation). > EndPointSnitch: rename to RackInferringSnitch > PropertyFileEndpointSnitch: rename to PropertyFileSnitch, move from contrib > to src > DatacenterEndpointSnitch: remove (redundant wrt PFS). "quorum factor per DC" > needs to go in the ReplicationStrategy, not the snitch. > The patch sequence looks like: > 01: perform renames of IEPS, AES, EPS, and PFES > 02: add SS and make method changes to ARAS [was AES] > Separate ticket: DatacenterReplicationStrategy code changes -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira