[ 
https://issues.apache.org/jira/browse/CASSANDRA-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865326#action_12865326
 ] 

Jonathan Ellis commented on CASSANDRA-1052:
-------------------------------------------

{code}
+            for (ColumnFamilyStore cfs : schemaStores)
             {
                 try
                 {
-                    f.get();
+                    cfs.forceBlockingFlush();
                 }
{code}

what you actually want to do is invoke flush on each, storing the futures you 
get back, then loop over the futures and call get() (which allows the flushes 
to parallelize).

also whitespace here looks suspicious :)

{code}
whitespace here looks suspicious:

+               new CFMetaData(Table.SYSTEM_TABLE, Migration.MIGRATIONS_CF, 
ColumnFamilyType.Standard, new TimeUUIDType(), null, "individual schema 
mutations", 0, false, 0),
+                new CFMetaData(Table.SYSTEM_TABLE, Migration.SCHEMA_CF, 
ColumnFamilyType.Standard, new UTF8Type(), null, "current state of the schema", 
0, false, 0)
{code}

+1 otherwise

> Move ks/cf definitions into system keyspace
> -------------------------------------------
>
>                 Key: CASSANDRA-1052
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1052
>             Project: Cassandra
>          Issue Type: Task
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Jonathan Ellis
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-move-ks-cf-definitions-into-system-keyspace.patch, 
> 0002-give-explicit-cfid-control-to-system-CFMs.patch
>
>
> Having a single keyspace for system metadata is cleaner than adding multiple 
> special cases. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to