[ 
https://issues.apache.org/jira/browse/CASSANDRA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870894#action_12870894
 ] 

Jonathan Ellis commented on CASSANDRA-1070:
-------------------------------------------

avoiding NPE by pushing it up to the caller is not preferred, e.g.

+        if (cfMetaData == null)
+            return null;
+        return cfMetaData.clockType;

better: 

assert cfMetaData != null;

> Update interface to use a wrapper for various clock types
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-1070
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1070
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Johan Oskarsson
>            Assignee: Sylvain Lebresne
>             Fix For: 0.7
>
>         Attachments: 
> 0001-Introduces-wrapper-for-clock-types-generalizing-time.patch, 
> 0001-v2-Introduces-wrapper-for-clock-types-generalizing-time.patch, 
> 0001-v4-Introduces-wrapper-for-clock-types-generalizing-time.patch, 
> 0001-v5-Introduces-wrapper-for-clock-types-generalizing-time.patch, 
> 0001-v6-Introduces-wrapper-for-clock-types-generalizing-time.patch, 
> 0002-Update-unit-tests.patch, 0002-v6-Update-unit-tests.patch, 
> 0003-Update-System-tests.patch, 0003-v6-Update-System-tests.patch
>
>
> In the latest CASSANDRA-580 patch the timestamp used for conflict resolution 
> has been replaced by a Clock object that can contain either timestamp or a 
> context byte array. That change allows for other conflict resolution 
> techniques to be used. 
> The change can be broken out and submitted here in order to make 
> CASSANDRA-580 more manageable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to