[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871152#action_12871152 ]
Jonathan Ellis commented on CASSANDRA-1105: ------------------------------------------- This is pretty good. I'd make one more change: instead of PropertyConfigurationTimerTask being tied to PropertyConfigurationLoadable, make it a more generic FileWatcher class that takes a Runnable to execute when changes are detected. (Then PCL isn't needed at all.) > Create timers to reload cassandra-rack.properties and datacenters.properties > ---------------------------------------------------------------------------- > > Key: CASSANDRA-1105 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1105 > Project: Cassandra > Issue Type: Task > Components: Core > Affects Versions: 0.7 > Reporter: Jonathan Ellis > Priority: Minor > Fix For: 0.7 > > Attachments: CASSANDRA-1105-2.patch, CASSANDRA-1105.patch > > > PropertyFileSnitch allows reloading changes from its config file manually. > DatacenterShardStrategy doesn't allow reloading at all [after I ripped out > the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103]. > Let's check each of these for changes (modification time on the fs is > sufficient) every minute and reload automatically if changes are seen. The > manual-reload code from PFS can then be dropped. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.