[ 
https://issues.apache.org/jira/browse/CASSANDRA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886843#action_12886843
 ] 

Jonathan Ellis commented on CASSANDRA-1249:
-------------------------------------------

doing string comparisons [on the version] for every key we read seems like a 
bad idea for performance.  that's the nice thing about the current code; you 
instantiate the right class once, and it never has to do any if-statements.

> Deprecate IPartitioner.(to|from)DiskFormat in favor of raw bytes
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1249
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Stu Hood
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-BloomFilter-fix-from-1218.patch, 
> 0002-Test-all-legacy-snapshots-and-generate-snapshot-for-.patch, 
> 0003-Remove-convertToDiskFormat-and-version-conditionally.patch
>
>
> RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, 
> which are inefficient and unnecessary

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to