[ https://issues.apache.org/jira/browse/CASSANDRA-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888335#action_12888335 ]
Hudson commented on CASSANDRA-1265: ----------------------------------- Integrated in Cassandra #491 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/491/]) > make getBuckets deterministic > ----------------------------- > > Key: CASSANDRA-1265 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1265 > Project: Cassandra > Issue Type: Sub-task > Components: Core > Affects Versions: 0.6.3 > Reporter: Jonathan Ellis > Assignee: Tyler L. Hobbs > Priority: Minor > Fix For: 0.6.4 > > Attachments: cassandra-0.6-1265.txt > > > CompactionManager.getBuckets is nondeterministic as explained in the parent > issue. > This can be fixed either by sorting in getBuckets, or requiring that the > iterable passed be sorted already. Either is fine. > We also need to add some unit tests to CompactionManagerTest for getBuckets. > We need to decouple getBuckets a little to do this sanely; rather than > examining sstable length directly or introducing some extra interface, let's > declare getBuckets as > static Set<List<T>> getBuckets(Iterable<Pair<T, Integer>> files, long min) > where the integer in the pair is the file size. Then you can write tests > against Strings instead of SSTableReaders. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.