[ 
https://issues.apache.org/jira/browse/CASSANDRA-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909469#action_12909469
 ] 

Nick Bailey commented on CASSANDRA-1504:
----------------------------------------

 * streamManagers should probably be renamed to streamSessions in 
Stream(In/Out)Session
 * StreamInSession uses a ConcurrentHashMap and StreamOutSession uses a 
NonBlockingHashMap 
 * Both session objects are pretty similar. Is "fix streaming VIII" going to be 
combining them? Should we just do that now?
 * StreamInSession
 ** files get added to the activeStreams set by IncomingStreamReader but never 
removed
 ** You removed activeStreams from getSources and getIncomingFIles. Personally 
I think those should be included but if not then there is no reason to keep 
activeStreams around.


> clean up streaming, part VII
> ----------------------------
>
>                 Key: CASSANDRA-1504
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1504
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7 beta 2
>
>         Attachments: 0001-rename-Manager-Session.txt, 
> 0002-avoid-exposing-StreamContext-outside-the-Session-manag.txt, 
> 0003-replace-StreamContext-with-Pair.txt, 
> 0004-replace-List-Map-with-LinkedHashMap.txt, 
> 0005-move-FileStatusHandler-methods-to-IncomingStreamReader.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to