[ https://issues.apache.org/jira/browse/CASSANDRA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909908#action_12909908 ]
Johan Oskarsson commented on CASSANDRA-1501: -------------------------------------------- The discussion seems to boil down to performance concerns of having TimestampClock wrap the timestamp long variable in the standard write path. I'm not convinced the overhead is big enough to be an issue. Would it not be similar to Long vs long for example? Have you measured it on a running Cassandra instance with a benchmark or profiler? Refactoring CASSANDRA-1072 to work without the internal clock code (IClock + impl, ClockType, Reconciler etc) is a massive undertaking and at this stage not even guaranteed to be feasible in the manner suggested with, I suspect, minimal benefits. > remove Clock from Thrift API > ---------------------------- > > Key: CASSANDRA-1501 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1501 > Project: Cassandra > Issue Type: Task > Components: API > Affects Versions: 0.7 beta 1 > Reporter: Jonathan Ellis > Assignee: Jonathan Ellis > Fix For: 0.7 beta 2 > > Attachments: 1501.txt > > > Clock was introduced back when we insufficiently understood the limitations > of CASSANDRA-580. It turns out to not be necessary. This ticket removes it > from the Thrift API to get ready for 0.7.0; removing it from the rest of the > internals can follow. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.