[ 
https://issues.apache.org/jira/browse/CASSANDRA-7843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137209#comment-14137209
 ] 

Benedict commented on CASSANDRA-7843:
-------------------------------------

I really don't have anything against static singletons. They make testing a bit 
harder, but there's not really anything wrong with them for development, so I 
don't really consider them technical debt as such. I am probably in the 
minority about that, of course, given the amount of disgust I've seen expressed 
about their presence.

Could we discuss some specific testing use cases we want to enable, that cannot 
be achieved through other means? It would be nice to get a handle on what the 
benefit is going to be.

bq.  I've also done the refactor in a way that can be reviewed and merged in 
smaller chunks.

There are > 400 _commits_. That will be much more challenging than you let on 
to even navigate, let alone review. It is likely to be both boring _and_ 
stressful.

> Remove static singleton instances
> ---------------------------------
>
>                 Key: CASSANDRA-7843
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7843
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>
> Initialize and start C* from a static method that takes a configuration as an 
> argument.
> CassandraDaemon and utilities will need to be updated, and we'll need a 
> helper method so tests can instantiate the database with a one or two liner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to