[ 
https://issues.apache.org/jira/browse/CASSANDRA-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926409#action_12926409
 ] 

Jonathan Ellis commented on CASSANDRA-1651:
-------------------------------------------

bq. The idea is to minimize allocation on intermediate byte[] copies

once you have the ByteBuffer you're good to go there whether you created it via 
wrap or allocate.  the only question is whether it's easier to write something 
like

{code}
if cfs.row_cache_enabled:
  allocate
else:
  wrap
{code}

or to deep-copy the CF to allocate()ed BB after the fact.  The first is going 
to be more performant (wrap + allocate later vs allocate initially) so the 
question is can we make the code sane.

> Improve read performance by using byte array slabs
> --------------------------------------------------
>
>                 Key: CASSANDRA-1651
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1651
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: T Jake Luciani
>            Assignee: T Jake Luciani
>            Priority: Minor
>             Fix For: 0.7.0
>
>         Attachments: 1651_v1.txt
>
>
> Now that the code has switched to byte buffers internally,  it should be 
> possible to improve read performance by reducing the number of byte array 
> allocations.
> This patch accomplishes this by and re-using sections of a larger byte array 
> slab.
> I've benchmarked it locally and seen a slight improvement on reads, a larger 
> scale benchmark should be performed.
> Also the size of a slab can be configured in cassandra.yaml

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to