[ 
https://issues.apache.org/jira/browse/CASSANDRA-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144934#comment-14144934
 ] 

Joshua McKenzie commented on CASSANDRA-7986:
--------------------------------------------

Note: This relies on applying part2 from CASSANDRA-6075 to behave.

Couple of points on the patch:
# Use FBUtilities.isUnix() instead of re-rolling your own isWindows() check
# nit: Comment in WindowsLocalFileSystem should read:
{noformat}          // Just swallow the Exception as logging it produces too 
much output. {noformat}

Might be worth keeping in mind that the setPermission method isn't doing 
anything useful and, as mentioned in the referenced hadoop ticket:
{quote}or, if you're feeling ambitious, does something more appropriate when 
trying to set them.{quote}

But for now, this seems sufficient to me to get the tests to run.  
Incidentally, this patch fixes running on Windows in general, not just under 
Cygwin.

+1 with those minor changes.

> The Pig tests cannot run on Cygwin on Windows
> ---------------------------------------------
>
>                 Key: CASSANDRA-7986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7986
>             Project: Cassandra
>          Issue Type: Bug
>         Environment: Windows 8.1, Cygwin 1.7.32 
>            Reporter: Benjamin Lerer
>            Assignee: Benjamin Lerer
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: CASSANDRA-7986.txt
>
>
> When running the Pig-Tests on Cygwin Windows I run into 
> https://issues.apache.org/jira/browse/HADOOP-7682. 
> Ideally this issue should be properly fix in HADOOP but as the issue is open 
> since September 2011 it will be good if we implemented the workaround 
> mentionned by Joshua Caplan for the Pig-Tests 
> (https://issues.apache.org/jira/browse/HADOOP-7682?focusedCommentId=13440120&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13440120)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to