[ https://issues.apache.org/jira/browse/CASSANDRA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242529#comment-14242529 ]
Sylvain Lebresne commented on CASSANDRA-4139: --------------------------------------------- To offer some kind of counter-point, I don't think this ticket would require lots of effort since we already have code to do the vint encoding/decoding. I might be missing something, but from what I can tell, it should be enough to pass the {{TypeSizes}} in {{IVersionedSerializer.serializedSize}} plus make sure both sides agree on whether vint is enabled or not, none of which is terribly involved (nor would add much complexity to the code). And since the investissement is not that big, I do think it's not completely worthless to evaluate it. It will probably not help in all cases or even with the default configuration, but I suspect it's faster than generic compression and so it could be interesting when you want a middle-ground between no compression at all and full messages compression. Anyway, not trying to convince anyone to prioritize this in any way, but just to say that unless someone beats me to it, I do intend to give this a shot at some point in the future (especially because some parts I made in CASSANDRA-8099 would benefit more from vint that what the current format probaby do). > Add varint encoding to Messaging service > ---------------------------------------- > > Key: CASSANDRA-4139 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4139 > Project: Cassandra > Issue Type: Sub-task > Components: Core > Reporter: Vijay > Assignee: Ariel Weisberg > Fix For: 3.0 > > Attachments: 0001-CASSANDRA-4139-v1.patch, > 0001-CASSANDRA-4139-v2.patch, 0001-CASSANDRA-4139-v4.patch, > 0002-add-bytes-written-metric.patch, 4139-Test.rtf, > ASF.LICENSE.NOT.GRANTED--0001-CASSANDRA-4139-v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)