[ 
https://issues.apache.org/jira/browse/CASSANDRA-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Eggleston updated CASSANDRA-8452:
---------------------------------------
    Attachment: CASSANDRA-8452-v2.patch

It looks like there's already a patch in the works for 2.1 in CASSANDRA-6993, 
should I close this as a duplicate?

If not, +1 on calculating at startup and calling it posix. The v2 patch 
attached determines OS on class initialization, and renames {{isUnix}} to 
{{isPosix}}. It also replaces a few {{!FBUtilities.isUnix()}} with 
{{FBUtilities.isWindows()}} where the comments indicate that the check is being 
done to support windows. Also, imo isPosix implies that the system is posix 
compliant, so I just changed it to isPosix, but lemme know if isPosixCompliant 
is strongly preferred, and I'll rename it.

> Add missing systems to FBUtilities.isUnix, add FBUtilities.isWindows
> --------------------------------------------------------------------
>
>                 Key: CASSANDRA-8452
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8452
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 2.1.3
>
>         Attachments: CASSANDRA-8452-v2.patch, CASSANDRA-8452.patch
>
>
> The isUnix method leaves out a few unix systems, which, after the changes in 
> CASSANDRA-8136, causes some unexpected behavior during shutdown. It would 
> also be clearer if FBUtilities had an isWindows method for branching into 
> Windows specific logic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to