[ https://issues.apache.org/jira/browse/CASSANDRA-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242969#comment-14242969 ]
Joshua McKenzie commented on CASSANDRA-8452: -------------------------------------------- I'm not sure if "isPosix" is correct in retrospect ([reference|http://en.wikipedia.org/wiki/POSIX#POSIX-oriented_operating_systems]). Not only are we not actually checking if something's truly posix compliant (though being mostly compliant serves our needs for now...), but our checks are more oriented around granular platform-specific differences, i.e. whether or not the underlying filesystem is an ext/hfs vs. ntfs, or whether or not the platform has a /proc filesystem (Note: I don't think the /proc filesystem is actually defined in the posix standard ([reference 2|http://pubs.opengroup.org/onlinepubs/9699919799/])). While having methods like 'isNTFS' or 'hasProcFilesystem' would be arguably more correct, at this point if we slice the eco-sytem into "Windows" vs. "non-Windows" it seems like it would satisfy our requirements. I could be off on that though - do we have areas in the code-base where we support specific sub-types of the *nix world w/different checks? i.e. is cassandra run on any systems that are currently missing a /proc filesystem, or have wacky hard-link behavior so early re-open is a problem, etc? > Add missing systems to FBUtilities.isUnix, add FBUtilities.isWindows > -------------------------------------------------------------------- > > Key: CASSANDRA-8452 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8452 > Project: Cassandra > Issue Type: Bug > Reporter: Blake Eggleston > Assignee: Blake Eggleston > Priority: Minor > Fix For: 2.1.3 > > Attachments: CASSANDRA-8452-v2.patch, CASSANDRA-8452.patch > > > The isUnix method leaves out a few unix systems, which, after the changes in > CASSANDRA-8136, causes some unexpected behavior during shutdown. It would > also be clearer if FBUtilities had an isWindows method for branching into > Windows specific logic. -- This message was sent by Atlassian JIRA (v6.3.4#6332)