[ 
https://issues.apache.org/jira/browse/CASSANDRA-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933206#action_12933206
 ] 

Bryan Tower edited comment on CASSANDRA-1753 at 11/17/10 5:27 PM:
------------------------------------------------------------------

This patch adds a check to the SSTableImportTest to make sure that the 
retrieved Column is not deleted and fixes the bug in the SSTableImport.java by 
switching the logic on the isDeletedCheck.
The patch is for the cassandra-0.7 branch.

      was (Author: bryantower):
    This patch adds a check to the SSTableImportTest to make sure that the 
retrieved Column is not deleted and fixes the bug in the SSTableImport.java by 
switching the logic on the isDeletedCheck. 
  
> SSTableImport adds columns marked for delete incorrectly in methods 
> addToStandardCF & addToSuperCF
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1753
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1753
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 0.7 beta 2
>            Reporter: Pushpinder Heer
>            Priority: Minor
>         Attachments: cassandra-0.7-1753.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The logic for adding column families in the methods addToStandardCF & 
> addToSuperCF appears to be backwards
>             if (col.isDeleted) {
>                 cfamily.addColumn(path, hexToBytes(col.value), new 
> TimestampClock(col.timestamp));
>             } else {
>                 cfamily.addTombstone(path, hexToBytes(col.value), new 
> TimestampClock(col.timestamp));
>             }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to