[
https://issues.apache.org/jira/browse/CASSANDRA-8707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304901#comment-14304901
]
Marcus Eriksson commented on CASSANDRA-8707:
--------------------------------------------
* class comments in RefCounted and Ref out of date (we don't have any
RefCounted.Impl anymore for example)
* make SegmentedFile.Cleanup abstract and remove the empty tidy implementation.
There is an instance created in BufferedSegmentedFile, I think it would be
clearer if the empty tidy() method is implemented there.
* A few unused SharedClosable imports in the *SegmentedFile files
Still waiting for a simplification of the class hierarchy in SSTableReader as
it is very hard to follow (though, yes, it is perhaps simpler than the linked
list approach).
If it is as simple as it can be, I'm almost inclined to suggest that we should
stop doing early opening of compaction results as I doubt the complexity is
worth it, we have had so many issues with this since we released it (quite a
few caused by me trying to fix other issues with it).
> Move SegmentedFile, IndexSummary and BloomFilter to utilising RefCounted
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-8707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8707
> Project: Cassandra
> Issue Type: Bug
> Reporter: Benedict
> Assignee: Benedict
> Priority: Critical
> Fix For: 2.1.3
>
>
> There are still a few bugs with resource management, especially around
> SSTableReader cleanup, esp. when intermixing with compaction. This migration
> should help. We can simultaneously "simplify" the logic in SSTableReader to
> not track the replacement chain, only to take a new reference to each of the
> underlying resources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
