[
https://issues.apache.org/jira/browse/CASSANDRA-8707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309214#comment-14309214
]
Benedict commented on CASSANDRA-8707:
-------------------------------------
bq. I just want a small 'why' instead of a comment stating the obvious:
I'm honestly not meaning to be obtuse here, I'm just looking for help. For some
of this code I struggle(d) to see how I could make it clearer, so just dropped
in a few comments willynilly. In your latter example, I do my best to explain
the why at the top of each of the Tidy classes, and especially the
InstanceTidier, that outlines the hierarchy. Here I was just duplicating some
information so that the concept that was being related to was directly
mentioned. This is why I ask for guidance, because whilst it may _now_ be clear
to you it wasn't before, but conversely it is not at all clear to me what
_isn't/wasn't_ clear, and I really need some help knowing where to fill in. The
why comments seem to already be there for me in that second example, excepting
the class-level outline of the lifecycle.
> Move SegmentedFile, IndexSummary and BloomFilter to utilising RefCounted
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-8707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8707
> Project: Cassandra
> Issue Type: Bug
> Reporter: Benedict
> Assignee: Benedict
> Priority: Critical
> Fix For: 2.1.3
>
>
> There are still a few bugs with resource management, especially around
> SSTableReader cleanup, esp. when intermixing with compaction. This migration
> should help. We can simultaneously "simplify" the logic in SSTableReader to
> not track the replacement chain, only to take a new reference to each of the
> underlying resources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
