[
https://issues.apache.org/jira/browse/CASSANDRA-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328280#comment-14328280
]
Jeff Jirsa edited comment on CASSANDRA-5791 at 2/21/15 4:53 AM:
----------------------------------------------------------------
Thanks for the feedback.
On whether or not a missing digest indicates corruption. In the case of a
missing digest, does it make more sense to imply --extended and verify atoms?
Doing that at least verifies the inline checksums for compressed sstables?
Most of the remaining nits are 100% valid, and due to me basing this on the
scrub path without eliminating all of the obsolete code. Cleaning up to
address. Only nit that seems inconsistent: sstableverify.bat ability to specify
CASSANDRA_MAIN is consistent with other similar tools (sstablescrub,
sstableupgrade, sstableloader, sstablekeys)
Updated for nits :
https://github.com/jeffjirsa/cassandra/compare/cassandra-5791 and/or
https://github.com/jeffjirsa/cassandra/compare/cassandra-5791.diff
was (Author: jjirsa):
Thanks for the feedback.
On whether or not a missing digest indicates corruption. In the case of a
missing digest, does it make more sense to imply --extended and verify atoms?
Doing that at least verifies the inline checksums for compressed sstables?
Most of the remaining nits are 100% valid, and due to me basing this on the
scrub path without eliminating all of the obsolete code. Cleaning up to
address. Only nit that seems inconsistent: sstableverify.bat ability to specify
CASSANDRA_MAIN is consistent with other similar tools (sstablescrub,
sstableupgrade, sstableloader, sstablekeys)
> A nodetool command to validate all sstables in a node
> -----------------------------------------------------
>
> Key: CASSANDRA-5791
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5791
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: sankalp kohli
> Assignee: Jeff Jirsa
> Priority: Minor
> Attachments: cassandra-5791.patch-2
>
>
> CUrrently there is no nodetool command to validate all sstables on disk. The
> only way to do this is to run a repair and see if it succeeds. But we cannot
> repair the system keyspace.
> Also we can run upgrade sstables but that re writes all the sstables.
> This command should check the hash of all sstables and return whether all
> data is readable all not. This should NOT care about consistency.
> The compressed sstables do not have hash so not sure how it will work there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
