[ 
https://issues.apache.org/jira/browse/CASSANDRA-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340976#comment-14340976
 ] 

Aleksey Yeschenko commented on CASSANDRA-8722:
----------------------------------------------

Shouldn't need validityPeriod/updateInterval/maxEntries fields in 
PermissionsCache, should just fetch those directly from DD.getWhatever().

Config.{permissions_validity_in_ms, permissions_cache_max_entries, 
permissions_update_interval_in_ms} should be made volatile

Nits:
- I'd prefer PermissionsCacheMBean#invalidatePermissions() to be renamed to 
PermissionsCacheMBean#invalidate(), and remove 'Permissions' from every other 
methods in there. It's already in the interface/mbean name, and is redundant.
- DatabaseDescriptor import in PermissionsCache is in teh wrong place.

LGTM otherwise.

> Auth MBean needs to be registered
> ---------------------------------
>
>                 Key: CASSANDRA-8722
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8722
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 2.1.4
>
>         Attachments: 8722-v2.txt, 8722.txt
>
>
> In CASSANDRA-7968 we created this bean but forgot to register it :(  This 
> also makes CASSANDRA-7977 unusable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to