[ 
https://issues.apache.org/jira/browse/CASSANDRA-8838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349709#comment-14349709
 ] 

Stefania commented on CASSANDRA-8838:
-------------------------------------

Hi Yuki, really nice code, here are my comments (mostly questions for my own 
benefit really):
\\
\\
* {{StreamStateStore.isDataAvailable()}} doesn't seem to be used

* In {{SystemKeyspace.getAvailableRanges()}} why do we need to copy the result 
into an {{ImmutableSet}}, just to make sure the caller cannot modify the result 
or is there more to it I should understand?

* Do we ever reset the available ranges? If not, is this not going to cause 
issues if the node is down for a very long time, like a few days or do we just 
rely on deleting the whole node data in these cases?

> Resumable bootstrap streaming
> -----------------------------
>
>                 Key: CASSANDRA-8838
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8838
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>            Priority: Minor
>              Labels: dense-storage
>             Fix For: 3.0
>
>
> This allows the bootstrapping node not to be streamed already received data.
> The bootstrapping node records received keyspace/ranges as one stream session 
> completes. When some sessions with other nodes fail, bootstrapping fails 
> also, though next time it re-bootstraps, already received keyspace/ranges are 
> skipped to be streamed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to