[ https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366954#comment-14366954 ]
Benedict commented on CASSANDRA-8584: ------------------------------------- Sorry for the delay, missed this in my work queue. LGTM. One nit to consider on commit is if we should increase the window for throttling - an error doing something like this probably doesn't need to be reported secondly, and probably not even minutely. Probably 10m+ is more like it IMO. > Add strerror output on failed trySkipCache calls > ------------------------------------------------ > > Key: CASSANDRA-8584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8584 > Project: Cassandra > Issue Type: Improvement > Reporter: Joshua McKenzie > Assignee: Joshua McKenzie > Priority: Trivial > Fix For: 2.1.4 > > Attachments: 8584_v1.txt, nospamlogger.txt > > > Since trySkipCache returns an errno rather than -1 and setting errno like our > other CLibrary calls, it's thread-safe and we could print out more helpful > information if we failed to prompt the kernel to skip the page cache. That > system call should always succeed unless we have an invalid fd as it's free > to ignore us. -- This message was sent by Atlassian JIRA (v6.3.4#6332)