[
https://issues.apache.org/jira/browse/CASSANDRA-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368778#comment-14368778
]
Sylvain Lebresne commented on CASSANDRA-8553:
---------------------------------------------
On v2:
* For the methods variant that don't take a {{customPayload}}, I was only
thinking of {{QueryProcessor}}, and I don't think adding them to the
{{QueryHandler}} makes much sense (it just makes it more annoying to implement
that interface).
* In {{Message.java}}, we should throw a {{ProtocolException}} rather than a
{{RuntimeException}} in the decoding case (could be cleaner in the encoding
case too but it matters less).
* The goal of using reflection in MessagePayloadTest was to avoid making
{{ClientState.cqlQueryHandler}} non final, but the patch still does it. You can
remove the final modifier through reflexion just for the test, see
[here|http://stackoverflow.com/questions/3301635/change-private-static-final-field-using-java-reflection].
It would also be cleaner imo to change/reset the handler in a
{{@BeforeTest}}/{{@AfterTest}} (or {{@BeforeClass}}/{{@AfterClass}}), including
moving the currently static parts (setting the field accessible) there and
turning the field not accessible again in the {{@AfterTest}} to make it clear
the test leave the global state of the JVM as it found it, which is good
hygiene).
* I believe you'll need to rebase since you've committed the change to
{{CQLTester}} separatly.
> Add a key-value payload for third party usage
> ---------------------------------------------
>
> Key: CASSANDRA-8553
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8553
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Sergio Bossa
> Assignee: Robert Stupp
> Labels: client-impacting, protocolv4
> Fix For: 3.0
>
> Attachments: 8553-v2.txt, 8553.txt
>
>
> An useful improvement would be to include a generic key-value payload, so
> that developers implementing a custom {{QueryHandler}} could leverage that to
> move custom data back and forth.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
