[
https://issues.apache.org/jira/browse/CASSANDRA-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368828#comment-14368828
]
Sam Tunnicliffe commented on CASSANDRA-8991:
--------------------------------------------
Looks reasonable to me, two minor things though:
* We don't use braces for single statement conditionals (despite that being
EVIL), so we should either remove those or (my preference) use ternary syntax.
* To avoid future confusion, it would be good to add a brief comment explaining
why the method was added as opposed to simply implementing
CFStatement#columnFamily() - i.e because we need columnFamily() to return null,
so that SchemaMigrations for dropping an index remain as keyspace rather than
table level events. For example, see SchemaAlteringStatement#execute
Lastly, it's preferred to suffix attached patches with .txt (I think this is to
make some browsers display the patch inline, rather than attempt to download
it).
> CQL3 DropIndexStatement should expose getColumnFamily like the CQL2 version
> does.
> ---------------------------------------------------------------------------------
>
> Key: CASSANDRA-8991
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8991
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Ulises Cervino Beresi
> Assignee: Ulises Cervino Beresi
> Priority: Minor
> Fix For: 2.0.14
>
> Attachments: CASSANDRA-2.0.13-8991.patch
>
>
> CQL3 DropIndexStatement should expose getColumnFamily like the CQL2 version
> does.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
