[
https://issues.apache.org/jira/browse/CASSANDRA-5174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369929#comment-14369929
]
Yuki Morishita commented on CASSANDRA-5174:
-------------------------------------------
* I think we should log only when we are rebuilding index, and change log level
to WARN, since default exception handler will log in ERROR anyway.
(https://github.com/stef1927/cassandra/blob/5174/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L1403)
* Why don't you handle IllegalArgumentException in its own catch block?
(https://github.com/stef1927/cassandra/blob/5174/src/java/org/apache/cassandra/tools/NodeTool.java#L1285)
Otherwise, +1.
dtest also looks good except coding styles (docstring, string format) but I let
QA team take a look when you do pull request.
> expose nodetool scrub for 2Is
> -----------------------------
>
> Key: CASSANDRA-5174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5174
> Project: Cassandra
> Issue Type: Task
> Components: Core, Tools
> Reporter: Jason Brown
> Assignee: Stefania
> Priority: Minor
> Fix For: 3.0
>
>
> Continuation of CASSANDRA-4464, where many other nodetool operations were
> added for 2Is. This ticket supports scrub fo 2Is and is in its own ticket due
> to the riskiness of deleting data on a bad bug.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
