[
https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483359#comment-14483359
]
Nick Bailey commented on CASSANDRA-8348:
----------------------------------------
bq. Also I think the imports should be managed properly and unnecessary imports
should be avoided
I'm fine with it personally. I didn't see anything in the contributor
guidelines so I think you are good to leave it.
bq. Regarding the other patch for 3.0 I cant find the branch for 3.0 version on
github https://github.com/apache/cassandra
3.0 is trunk, you likely need an additional patch for the 2.1 branch.
https://github.com/apache/cassandra/tree/cassandra-2.1
Other notes,
* You added some tabs into this new patch. Whitespace should be spaces only.
* Your check "if (splittedString.length == 2)" will catch both cases where a
column family isn't passed in or a secondary index is passed in. Can probably
remove those additional checks in the if block and update the error message.
So nothing major to change, looks good to me besides that.
> allow takeColumnFamilySnapshot to take a list of ColumnFamilies
> ---------------------------------------------------------------
>
> Key: CASSANDRA-8348
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8348
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Peter Halliday
> Priority: Minor
> Fix For: 2.1.5
>
> Attachments: 8348_v2.patch, Patch-8348.patch
>
>
> Within StorageServiceMBean.java the function takeSnapshot allows for a list
> of keyspaces to snapshot. However, the function takeColumnFamilySnapshot
> only allows for a single ColumnFamily to snapshot. This should allow for
> multiple ColumnFamilies within the same Keyspace.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
