[ https://issues.apache.org/jira/browse/CASSANDRA-8358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504083#comment-14504083 ]
Aleksey Yeschenko commented on CASSANDRA-8358: ---------------------------------------------- Force pushed another updated (and squashed) version to the same branch - https://github.com/iamaleksey/cassandra/commits/8358. It adds some more cleanup on top of Philip's, in particular some around SSTableLoader.Client implementations, but it's still far from clean - because of original code dirtiness. Things that need fixing: - NativeSSTableLoaderClient must support connecting over SSL. This is a regression - the original code did support this. - NSSTLC TalbeMetadata to CFMetaData code is broken. I think we should, for now, do the ugly thing and reimplement what sstableloader was doing, and SELECT stuff from schema table manually, then do the equivalent of {{ThriftConversion.fromThriftCqlRow()}} call, now unused. > Bundled tools shouldn't be using Thrift API > ------------------------------------------- > > Key: CASSANDRA-8358 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8358 > Project: Cassandra > Issue Type: Improvement > Reporter: Aleksey Yeschenko > Assignee: Philip Thompson > Fix For: 3.0 > > > In 2.1, we switched cqlsh to the python-driver. > In 3.0, we got rid of cassandra-cli. > Yet there is still code that's using legacy Thrift API. We want to convert it > all to use the java-driver instead. > 1. BulkLoader uses Thrift to query the schema tables. It should be using > java-driver metadata APIs directly instead. > 2. o.a.c.hadoop.cql3.CqlRecordWriter is using Thrift > 3. o.a.c.hadoop.ColumnFamilyRecordReader is using Thrift > 4. o.a.c.hadoop.AbstractCassandraStorage is using Thrift > 5. o.a.c.hadoop.pig.CqlStorage is using Thrift > Some of the things listed above use Thrift to get the list of partition key > columns or clustering columns. Those should be converted to use the Metadata > API of the java-driver. > Somewhat related to that, we also have badly ported code from Thrift in > o.a.c.hadoop.cql3.CqlRecordReader (see fetchKeys()) that manually fetches > columns from schema tables instead of properly using the driver's Metadata > API. > We need all of it fixed. One exception, for now, is > o.a.c.hadoop.AbstractColumnFamilyInputFormat - it's using Thrift for its > describe_splits_ex() call that cannot be currently replaced by any > java-driver call (?). > Once this is done, we can stop starting Thrift RPC port by default in > cassandra.yaml. -- This message was sent by Atlassian JIRA (v6.3.4#6332)