[ https://issues.apache.org/jira/browse/CASSANDRA-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sam Tunnicliffe updated CASSANDRA-9334: --------------------------------------- Attachment: 9334-2.0.txt 9334-test-trunk.txt I've attached a couple of trivial patches, the first is against 2.0 to fix up the javadoc and the second against trunk to add a test verifying the current behaviour on throwing an exception from {{ITrigger#execute}}. > Returning null from a trigger does not abort the write > ------------------------------------------------------ > > Key: CASSANDRA-9334 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9334 > Project: Cassandra > Issue Type: Bug > Components: Core > Reporter: Brandon Williams > Assignee: Sam Tunnicliffe > Fix For: 2.0.x > > Attachments: 9334-2.0.txt, 9334-test-trunk.txt > > > The javadoc for ITrigger seems to indicate that returning null means no > mutations for the write will be applied at all: > {noformat} > * Called exactly once per CF update, returned mutations are atomically > updated. > * > * @param key - Row Key for the update. > * @param update - Update received for the CF > * @return modifications to be applied, null if no action to be performed. > {noformat} > and indeed, TriggerExecutor.execute seems to have code for this: > {noformat} > if (augmentedMutations == null) > return null; > {noformat} > but it never fires. In testing with a trigger that always returns null, the > original mutation is still applied. -- This message was sent by Atlassian JIRA (v6.3.4#6332)