[ 
https://issues.apache.org/jira/browse/CASSANDRA-9532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579120#comment-14579120
 ] 

mck edited comment on CASSANDRA-9532 at 6/9/15 3:48 PM:
--------------------------------------------------------

Working with just 9532-2.0-v2.txt

 looks great! thanks heaps. it solves the original ticket description and that 
in the 
[comment|https://issues.apache.org/jira/browse/CASSANDRA-9532?focusedCommentId=14570398&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14570398]
 above.

Something trivial, in SelectionColumnMapping could the \*ColumnMapping\* 
methods be shortened to \*Mapping\*, eg{noformat} .addColumnMapping(colSpec, 
column) --> .addMapping(colSpec, column)
 .addColumnMapping(colSpec, columns) --> .addMapping(colSpec, columns)
 .getColumnMappings() --> .getMappings(){noformat}
Only noticed because 
{{selectStatement.selection.getColumnMapping().getColumnMappings()}} looked a 
little odd at first glance, and maybe   
{{selectStatement.selection.getColumnMapping().getMappings()}} would read 
better, but it's on the banally trivial side of things.



was (Author: michaelsembwever):
Working with just 9532-2.0-v2.txt

 looks great! thanks heaps. it solves the original ticket description and that 
in the 
[comment|https://issues.apache.org/jira/browse/CASSANDRA-9532?focusedCommentId=14570398&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14570398]
 above.

 and the trivial, in SelectionColumnMapping could the \*ColumnMapping\* methods 
be shortened to \*Mapping\*, eg{noformat} .addColumnMapping(colSpec, column) 
--> .addMapping(colSpec, column)
 .addColumnMapping(colSpec, columns) --> .addMapping(colSpec, columns)
 .getColumnMappings() --> .getMappings(){noformat}
Only noticed because 
{{selectStatement.selection.getColumnMapping().getColumnMappings()}} looked a 
little odd at first glance, and maybe   
{{selectStatement.selection.getColumnMapping().getMappings()}} would read 
better, but it's on the banally trivial side of things.


> Provide access to select statement's real column definitions
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-9532
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9532
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: mck
>            Assignee: mck
>             Fix For: 3.x, 2.1.x, 2.0.x, 2.2.x
>
>         Attachments: 9532-2.0-v2.txt, 9532-2.1-v2.txt, 9532-2.2-v2.txt, 
> 9532-trunk-v2.txt, cassandra-2.0-9532.txt, cassandra-2.1-9532.txt, 
> cassandra-2.2-9532.txt, trunk-9532.txt
>
>
> Currently there is no way to get access to the real ColumnDefinitions being 
> used in a SelectStatement.
> This information is there in
> {{selectStatement.selection.columns}} but is private.
> Giving public access would make it possible for third-party implementations 
> of a {{QueryHandler}} to work accurately with the real columns being queried 
> and not have to work-around column aliases (or when the rawSelectors don't 
> map directly to ColumnDefinitions, eg in Selection.fromSelectors(..), like 
> functions), which is what one has to do today with going through 
> ResultSet.metadata.names.
> This issue provides a very minimal patch to provide access to the already 
> final and immutable fields.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to